feat: add the capability to reload the current search #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarodE
previously approved these changes
Jun 12, 2024
manuel-cid
force-pushed
the
feat/reload-search
branch
from
1604e0b to
25466c7
Compare
alvarodE
previously approved these changes
Jun 13, 2024
Comment on lines
50
to
51
| const resettable = resettableState(); | ||
| resettable.query = state.query; | ||
| resettable.facets = state.facets as never[]; | ||
| resettable.sort = state.sort; | ||
| resettable.page = state.page; | ||
| Object.assign(state, resettable); |
There was a problem hiding this comment.
I was wondering a simpler implementation of this function and the only way I think it could be done would be like this, if you like it I leave it here to use it 😉
Suggested change
| const resettable = resettableState(); | |
| resettable.query = state.query; | |
| resettable.facets = state.facets as never[]; | |
| resettable.sort = state.sort; | |
| resettable.page = state.page; | |
| Object.assign(state, resettable); | |
| const { query, facets, sort, page, ...resettable } = resettableState(); | |
| Object.assign(state, resettable); |
manuel-cid
force-pushed
the
feat/reload-search
branch
3 times, most recently
from
6e11862 to
493563b
Compare
diegopf
requested changes
Jun 17, 2024
| /** | ||
| * Reload the current search has been requested. | ||
| */ | ||
| ReloadSearchRequested: undefined; |
There was a problem hiding this comment.
Suggested change
| ReloadSearchRequested: undefined; | |
| ReloadSearchRequested: void; |
manuel-cid
force-pushed
the
feat/reload-search
branch
from
493563b to
ab634d0
Compare
diegopf
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
We need a way to refresh the results displayed on the search layer.
Motivation and context
This requirement comes from the Backroom's next functionality, boost&bury of single products by query. After boosting or burying a product, we need a way to re-do the current search and refresh the results to see the change applied.
The idea is to emit the event
ReloadSearchRequestedthrough the x-bus and trigger a mutation on the state that triggers the search request.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: